bkietz commented on a change in pull request #10782:
URL: https://github.com/apache/arrow/pull/10782#discussion_r676736686
##########
File path: cpp/src/arrow/csv/column_builder_test.cc
##########
@@ -400,6 +400,24 @@ TEST_F(InferringColumnBuilderTest, MultipleChunkDate) {
ArrayFromJSON(date32(), "[null]")});
}
+TEST_F(InferringColumnBuilderTest, SingleChunkTime) {
+ auto options = ConvertOptions::Defaults();
+ auto tg = TaskGroup::MakeSerial();
+
+ CheckInferred(tg, {{"", "01:23:45", "NA"}}, options,
Review comment:
I mean: I'm guessing that in the case of `"", "99", "01:23:45"` we'd
fall back to string since we have an integer (definitely not a time, timestamp,
...) and a time (definitely not an integer, float, ...). That seems worth
testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
