alamb commented on a change in pull request #775:
URL: https://github.com/apache/arrow-datafusion/pull/775#discussion_r677015693



##########
File path: ballista-examples/Cargo.toml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[package]
+name = "ballista-examples"
+description = "Ballista usage examples"
+version = "0.5.0-SNAPSHOT"
+homepage = "https://github.com/apache/arrow-datafusion";
+repository = "https://github.com/apache/arrow-datafusion";
+authors = ["Apache Arrow <[email protected]>"]
+license = "Apache-2.0"
+keywords = [ "arrow", "distributed", "query", "sql" ]
+edition = "2018"
+publish = false
+
+

Review comment:
       I wonder if it is worth adding `bin` targets here?
   
   As it is I can't run these examples:
   
   ```shell
   (arrow_dev) alamb@MacBook-Pro:~/Software/arrow-datafusion/ballista-examples$ 
cargo run 
   error: a bin target must be available for `cargo run`
   ```
   
   Maybe something like
   ```toml
   [[bin]]
   name = "dataframe"
   path = "src/ballista_dataframe.rs"
   ```

##########
File path: ballista/README.md
##########
@@ -35,9 +35,30 @@ Ballista can be deployed as a standalone cluster and also 
supports [Kubernetes](
 case, the scheduler can be configured to use [etcd](https://etcd.io/) as a 
backing store to (eventually) provide
 redundancy in the case of a scheduler failing.
 
+# Getting Started
+
+Fully working examples are available. Refer to the [Ballista Examples 
README](../ballista-examples/README.md) for 
+more information.
+
+## Distributed Scheduler Overview
+
+Ballista uses the DataFusion query execution framework to create a physical 
plan and then transforms it into a 
+distributed physical plan by breaking the query down into stages whenever the 
partitioning scheme changes.
+
+Specifically, any `RepartitionExec` operatoris is replaced with an 
`UnresolvedShuffleExec` and the child operator 

Review comment:
       ```suggestion
   Specifically, any `RepartitionExec` operator is is replaced with an 
`UnresolvedShuffleExec` and the child operator 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to