emkornfield commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r677952982
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1490,7 +1490,8 @@ Status TypedColumnWriterImpl<DType>::WriteArrowDictionary(
// TODO(wesm): If some dictionary values are unobserved, then the
Review comment:
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L530
and
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L584
I thought I traced the code an we currently populate them but I could be
mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
