[GitHub] [arrow] nealrichardson commented on a change in pull request #10710: ARROW-11460: [R] Use system libraries if present on Linux

[GitBox]

nealrichardson commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r678430566



##########
File path: r/configure
##########
@@ -268,6 +269,11 @@ else
   PKG_CFLAGS=""
 fi
 
+
+if [ "$ARROW_DEPENDENCY_SOURCE" == "AUTO" ]; then

Review comment:
       Also, before L160 (the call to nixlibs.R), add something like:
   
   ```
   if [ "${ARROW_DEPENDENCY_SOURCE}" = "" ]; then
     # TODO: BUNDLED is still default for now, but we plan to change it to AUTO
     ARROW_DEPENDENCY_SOURCE=BUNDLED; export ARROW_DEPENDENCY_SOURCE
   fi
   if [ "${ARROW_DEPENDENCY_SOURCE}" = "AUTO" ]; then
     which pkg-config >/dev/null 2>&1
     if [ $? -eq 0 ]; then
       export ARROW_DEPENDENCY_SOURCE=BUNDLED
       # echo something?
     fi
   fi
   ```
   
   Finally, you also need to edit build_arrow_static.sh to take 
ARROW_DEPENDENCY_SOURCE from the environment (default arg there BUNDLED)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org