Dandandan commented on issue #790: URL: https://github.com/apache/arrow-datafusion/issues/790#issuecomment-888537528
> > Before implementing this proposal it is I think be possible with minimal changes to also to include a null part in the hashmap key, so the key would become something like (bool, Vec<u8>) as hashmap key > > @Dandandan I think this is a version of what I was trying to explain in the "Alternatives" considered section. I think we need an entire validity mask (as only some of the group keys might be null). Also, we would need to keep validity in the hash map's *values* to produce the correct output , but we could get that "for free" switching to `ScalarValue` ala https://github.com/apache/arrow-datafusion/pull/788 > > Yes, that's right. I missed the part in the alternatives, but that should work I think👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
