alamb commented on pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#issuecomment-890031194
Thanks for the reviews @Dandandan and @jhorstmann ! I plan to wait another day or two to see if anyone else has feedback on this approach, but what I am thinking of doing is merging this PR (after addressing comments) so at least we get correct answers and then work on the more sophisticated implementation in parallel. > Looks good. I was trying to come up with an example where two distinct keys would end up as the same encoding but could not find any because any variable length types include the length prefix. 🚀 Thanks for double checking -- this also worried me a lot so I am glad to hear someone else did a double check too. I convinced myself that since each key had entries for the same columns in the same order, there was no way to concoct the same bytes with different column values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
