ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r680129299



##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+## Benchmark Builds Env
+This directory contains 
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars 
used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks 
using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark 
builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built 
from source

Review comment:
       @bkietz Thank you so much for the review.
   
   I also added this comment. I hope it is ok.
   `- benchmark builds are run using `@ursabot please benchmark` PR comment to 
confirm that function definition updates do not break benchmark builds.`. 
   
   
https://github.com/apache/arrow/pull/10667/files#diff-04649ad45f96fd68437c83c30ad9dd25df8f6cf865d2a799b860eb7a159e11fcR47




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to