Dandandan commented on a change in pull request #644:
URL: https://github.com/apache/arrow-rs/pull/644#discussion_r680365425
##########
File path: arrow/src/array/array_string.rs
##########
@@ -103,28 +104,12 @@ impl<OffsetSize: StringOffsetSizeTrait>
GenericStringArray<OffsetSize> {
}
/// Returns the element at index `i` as &str
+ #[inline]
pub fn value(&self, i: usize) -> &str {
assert!(i < self.data.len(), "StringArray out of bounds access");
- //Soundness: length checked above, offset buffer length is 1 larger
than logical array length
Review comment:
Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
