thisisnic commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r681068165
##########
File path: r/configure
##########
@@ -80,7 +80,8 @@ elif [ "$INCLUDE_DIR" ] && [ "$LIB_DIR" ]; then
else
# Use pkg-config if available and allowed
pkg-config --version >/dev/null 2>&1
- if [ $? -eq 0 ] && [ "$ARROW_USE_PKG_CONFIG" != "false" ]; then
+ if [ $? -eq 0 ] && [ "$ARROW_USE_PKG_CONFIG" != "false" ] && [
"$ARROW_DEPENDENCY_SOURCE" == "AUTO" ]; then
Review comment:
I don't disagree! I'm still working on this - converted it to a draft
for the moment whilst I go read up on things as I realised I was just changing
code as per all the helpful suggestions, but not understanding why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
