Christian8491 commented on a change in pull request #10855:
URL: https://github.com/apache/arrow/pull/10855#discussion_r681883166
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -395,6 +395,12 @@ TYPED_TEST(TestStringKernels, AsciiLower) {
"[\"aaazzæÆ&\", null, \"\", \"bbb\"]");
}
+TYPED_TEST(TestStringKernels, AsciiSwapCase) {
+ this->CheckUnary("ascii_swapcase", "[]", this->type(), "[]");
+ this->CheckUnary("ascii_swapcase", "[\"aAazZæÆ&\", null, \"\", \"BbB\"]",
this->type(),
+ "[\"AaAZzæÆ&\", null, \"\", \"bBb\"]");
Review comment:
Sure. Addressed in
[8f65c70](https://github.com/apache/arrow/pull/10855/commits/8f65c700ae86d03d594dcf8957f7f17a583b2a97)
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -493,6 +499,23 @@ TYPED_TEST(TestStringKernels, Utf8Lower) {
CallFunction("utf8_lower", {invalid_input}));
}
+TYPED_TEST(TestStringKernels, Utf8SwapCase) {
+ this->CheckUnary("utf8_swapcase", "[\"aAazZæÆ&\", null, \"\", \"b\"]",
this->type(),
+ "[\"AaAZzÆæ&\", null, \"\", \"B\"]");
Review comment:
Also addressed in
[8f65c70](https://github.com/apache/arrow/pull/10855/commits/8f65c700ae86d03d594dcf8957f7f17a583b2a97)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
