ianmcook commented on a change in pull request #10722:
URL: https://github.com/apache/arrow/pull/10722#discussion_r682248376
##########
File path: r/R/dplyr-summarize.R
##########
@@ -28,14 +28,107 @@ summarise.arrow_dplyr_query <- function(.data, ...,
.engine = c("arrow", "duckdb
dplyr::group_vars(.data) # vars needed for grouping
))
.data <- dplyr::select(.data, vars_to_keep)
-
if (match.arg(.engine) == "duckdb") {
dplyr::summarise(to_duckdb(.data), ...)
- } else {
- if (query_on_dataset(.data)) {
- not_implemented_for_dataset("summarize()")
+ } else if (isTRUE(getOption("arrow.summarize", FALSE))) {
Review comment:
Is this `arrow.summarize` option intended for development/test purposes
only? Do you intend to remove it before the 6.0.0 release? If so we should open
a Jira for it with priority = blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
