nealrichardson commented on a change in pull request #10722:
URL: https://github.com/apache/arrow/pull/10722#discussion_r682596520
##########
File path: r/R/dplyr-summarize.R
##########
@@ -28,14 +28,107 @@ summarise.arrow_dplyr_query <- function(.data, ...,
.engine = c("arrow", "duckdb
dplyr::group_vars(.data) # vars needed for grouping
))
.data <- dplyr::select(.data, vars_to_keep)
-
if (match.arg(.engine) == "duckdb") {
dplyr::summarise(to_duckdb(.data), ...)
- } else {
- if (query_on_dataset(.data)) {
- not_implemented_for_dataset("summarize()")
+ } else if (isTRUE(getOption("arrow.summarize", FALSE))) {
Review comment:
I removed the flag now. It had the side effect of raising the warning
you asked about below in the unsupported cases. This is probably the right path
forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
