lidavidm commented on a change in pull request #10878:
URL: https://github.com/apache/arrow/pull/10878#discussion_r682895881
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1186,9 +1186,9 @@ TYPED_TEST(TestStringKernels, BinaryJoin) {
auto expected =
ArrayFromJSON(this->type(), R"(["a--bb--ccc", "", null, "dd", null,
"ff--"])");
CheckScalarBinary("binary_join", ArrayFromJSON(list(this->type()),
list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
CheckScalarBinary("binary_join", ArrayFromJSON(large_list(this->type()),
list_json),
- separator, expected);
+ static_cast<Datum>(separator), expected);
Review comment:
Ah, this isn't a cast, but is instead invoking the implicit conversion
([case (1) here](https://en.cppreference.com/w/cpp/language/static_cast)). Can
we write it as just `Datum(separator)` to make that clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
