lidavidm commented on a change in pull request #10880:
URL: https://github.com/apache/arrow/pull/10880#discussion_r682919988
##########
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##########
@@ -2035,7 +2035,7 @@ Result<std::shared_ptr<ChunkedArray>> TakeCC(const
ChunkedArray& values,
ARROW_ASSIGN_OR_RAISE(new_chunks[i],
Concatenate(current_chunk->chunks(),
ctx->memory_pool()));
}
- return std::make_shared<ChunkedArray>(std::move(new_chunks));
+ return std::make_shared<ChunkedArray>(std::move(new_chunks), values.type());
Review comment:
Thanks for fixing this!
There's a similar case down on line 2051 here - that should probably be
fixed too.
We should also add test cases to make sure this doesn't regress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
