westonpace commented on pull request #3:
URL: https://github.com/apache/arrow-cookbook/pull/3#issuecomment-893156412


   This looks good, I was able to get it to build on my fork.  I'll merge.  I 
wonder if we might want to do something slightly different though.
   
   This will checkout the existing gh-pages branch, update it, and then push.  
However, this has a few downsides:
   
   * It will fail if the gh-pages branch doesn't exist
   * It will keep a git history for gh-pages (I don't think we want this for 
built artifacts)
   * It might leave behind files that get removed (I think the current "add 
all" will only capture new or modified files)
   
   Alternatively, we could checkout the main branch initially (just to get 
origin setup), use "checkout --orphan" to create a brand new slate.  Do "add 
all / commit".  Force push to gh-pages.
   
   If this sounds good to you I'd be happy to work it through.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to