JayjeetAtGithub commented on pull request #10431:
URL: https://github.com/apache/arrow/pull/10431#issuecomment-892887455


   @westonpace @lidavidm Thanks for taking the time to explain in detail the 
proper way to contribute skyhook into arrow. I am writing down some action plan 
that I figured out from the discussion till now. I guess I will break down this 
PR into 3 parts now 
   
   i) An initial C++ implementation of skyhook (both `SkyhookFileFormat` and 
the object class code) placed in `cpp/src/skyhook/client` and 
`cpp/src/skyhook/cls`. We can place the protocol (like the ScanRequest and the 
helper serializer/deserialize methods) in `cpp/src/skyhook/protocol` and use it 
in both the client and CLS code.  Here we will build two libraries: a 
`libarrow_skyhook_client.so` for the client-side file format extensions and a 
`libcls_skyhook.so` for the CLS side Ceph object classes. Some unit/integration 
tests would also be included.
    
   ii) The python bindings for the `SkyhookFileFormat` extension with python 
unit tests.
   iii) Other misc. improvements to the code change to finalize it for merging.
   
   I would like to keep this PR open as a reference to all the valuable reviews 
that you have given so that I can incorporate all of them in my 1st PR with the 
minimal C++ implementations. Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to