lidavidm commented on a change in pull request #10877:
URL: https://github.com/apache/arrow/pull/10877#discussion_r684392252
##########
File path: cpp/src/arrow/filesystem/s3fs.h
##########
@@ -72,17 +72,24 @@ enum class S3CredentialsKind : int8_t {
/// Pure virtual class for describing custom S3 retry strategies
class S3RetryStrategy {
public:
+ /// Simple struct where each field corresponds to a field in
Aws::Client::AWSError
struct AWSErrorDetail {
+ /// Corresponds to AWSError::GetErrorType()
int error_type;
+ /// Corresponds to AWSError::GetMessage()
std::string message;
+ /// Corresponds to AWSError::GetExceptionName()
std::string exception_name;
+ /// Corresponds to AWSError::ShouldRetry()
bool should_retry;
};
/// Returns true if the S3 request resulting in the provided error should be
retried.
- virtual bool ShouldRetry(const AWSErrorDetail& error, long
attempted_retries) = 0;
+ virtual bool ShouldRetry(const AWSErrorDetail& error,
+ long attempted_retries) = 0; // NOLINT runtime/int
Review comment:
Ah, sorry, one final nit - can we use int64_t for these parameters too
instead of adding NOLINT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
