eerhardt commented on a change in pull request #10527:
URL: https://github.com/apache/arrow/pull/10527#discussion_r684687694
##########
File path: csharp/src/Apache.Arrow/Ipc/ArrowStreamWriter.cs
##########
@@ -128,6 +129,15 @@ public void Visit(StructArray array)
}
}
+ public void Visit(DictionaryArray array)
+ {
+ //Dictionary is serialized separately in Dictionary
serialization.
+ //We are only interested in indexes at this context.
Review comment:
(nits) comments usually have a space between the slashes and the first
character. Also `indexes` => `indices`.
```suggestion
// Dictionary is serialized separately in Dictionary
serialization.
// We are only interested in indices at this context.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
