nealrichardson commented on pull request #10879: URL: https://github.com/apache/arrow/pull/10879#issuecomment-895293565
> > Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code. > > Hi @nealrichardson, can you maybe tell us a bit more about problems with that so we could improve that? @lorenzwalthert the first thing I found was that, while style-on-save would clearly do something (like remove extra whitespace), I was still getting lint warnings about files not having a trailing newline. I didn't get this if I just ran `styler` directly on the file. Later, it seemed like the style-on-save wasn't firing at all. I figured it was possible that either of those could just be user error, and I wanted a simple (to me) way to re-style all of the files anyway, so I added these `make` commands. If it would be helpful, I'm happy to write an issue somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
