Dandandan commented on a change in pull request #845:
URL: https://github.com/apache/arrow-datafusion/pull/845#discussion_r685332096
##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -745,9 +747,12 @@ fn build_join_indexes(
&keys_values,
)? {
left_indices.append_value(i)?;
- } else {
- left_indices.append_null()?;
+ right_indices.append_value(row as u32)?;
Review comment:
This is the fix, instead of adding the (left=null, right) to every
non-match, it does it only once at the end if there wasn't a single match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
