pitrou commented on pull request #10895:
URL: https://github.com/apache/arrow/pull/10895#issuecomment-895376223


   Hmm... It's weird that `Count` takes `ScalarAggregateOptions`, yet 1) 
completely ignores `min_count` 2) has an unexpected interpretation of 
`skip_nulls`.
   
   Can we instead make `Count` take a `CountOptions` that would have a enum 
describing whether one wants to 1) count non-nulls 2) count nulls 3) count 
everything?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to