pitrou commented on a change in pull request #10890:
URL: https://github.com/apache/arrow/pull/10890#discussion_r685367287
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -1011,6 +1012,118 @@ struct GroupedSumFactory {
InputType argument_type;
};
+// ----------------------------------------------------------------------
+// Product implementation
+
+using arrow::internal::MultiplyWithOverflow;
+
+template <typename Type>
+struct GroupedProductImpl final : public GroupedAggregator {
+ using AccType = typename FindAccumulatorType<Type>::Type;
+ using ProductType = typename TypeTraits<AccType>::CType;
+
+ Status Init(ExecContext* ctx, const FunctionOptions*) override {
+ pool_ = ctx->memory_pool();
+ products_ = TypedBufferBuilder<ProductType>(pool_);
+ valid_ = TypedBufferBuilder<bool>(pool_);
+ out_type_ = TypeTraits<AccType>::type_singleton();
+ return Status::OK();
+ }
Review comment:
The options are not taken into account (e.g. `min_count = 2`)?
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -47,6 +47,9 @@ using applicator::ScalarUnaryNotNull;
namespace {
+// N.B. take care not to conflict with type_traits.h as that can cause
surprises in a
+// unity build
Review comment:
:-D
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -189,6 +189,53 @@ TEST(TestBooleanAggregation, Sum) {
ResultWith(Datum(MakeNullScalar(uint64()))));
}
+TEST(TestBooleanAggregation, Product) {
+ const ScalarAggregateOptions& options = ScalarAggregateOptions::Defaults();
+ ValidateBooleanAgg<Product>("[]", std::make_shared<UInt64Scalar>(), options);
Review comment:
According to the declarations above, shouldn't `Product(booleans)`
return a `Int64Scalar`?
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -133,6 +134,116 @@ Result<std::unique_ptr<KernelState>>
MeanInit(KernelContext* ctx,
return visitor.Create();
}
+// ----------------------------------------------------------------------
+// Product implementation
+
+using arrow::internal::MultiplyWithOverflow;
+
+template <typename ArrowType>
+struct ProductImpl : public ScalarAggregator {
+ using ThisType = ProductImpl<ArrowType>;
+ using CType = typename ArrowType::c_type;
+ using ProductType = typename FindAccumulatorType<ArrowType>::Type;
+ using OutputType = typename TypeTraits<ProductType>::ScalarType;
+
+ explicit ProductImpl(const ScalarAggregateOptions& options) { this->options
= options; }
+
+ Status Consume(KernelContext*, const ExecBatch& batch) override {
+ if (batch[0].is_array()) {
+ const auto& data = batch[0].array();
+ this->count += data->length - data->GetNullCount();
+ return VisitArrayDataInline<ArrowType>(
+ *data,
+ [&](typename TypeTraits<ArrowType>::CType value) {
+ if (ARROW_PREDICT_FALSE(
+ MultiplyWithOverflow(this->product, value,
&this->product))) {
+ return Status::Invalid("Overflow in product");
+ }
+ return Status::OK();
+ },
+ [] { return Status::OK(); });
+ } else {
+ const auto& data = *batch[0].scalar();
+ this->count += data.is_valid * batch.length;
Review comment:
Hmm... in which circumstances can `batch.length` be greater than 1 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
