aocsa commented on pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#issuecomment-895768466


   I updated the PR addressing feedback. 
   
   The following test cases were added.
   - 0-lengthed inputs (to test the early termination code paths)
   - non-zero but all null values on inputs (to test the early termination code 
paths)
   - Larger test case with more random values (say 1000 or so) --> Because 
bitmap ops work on 8 elements together. So, we need to test beyond 8 elements 
in an array.
   - Test with non-zero offsets in the inputs (for chunkedarrays and tables)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to