thisisnic commented on pull request #26: URL: https://github.com/apache/arrow-cookbook/pull/26#issuecomment-896809447
This looks good and solves the specific problem in a much cleaner way than before, but I think this might not be what we want to do in the context of other issues like #23 In #23 , I'm looking at splitting out the CI into jobs that are dependent on which folder has been updated, so we're not attempting to rebuild all cookbooks when changes has been made to just one. I imagine that as more implementations are added, this would increasingly slow down our CI. I'm still working out how exactly to do this, but I think a solution involves having separate CI jobs for cookbook builds which are only triggered when that cookbook version has been updated, and then just those changes are copied to the relevant subdirectory of `build` and then pushed to the gh-pages branch. I think we'd need to do something like `git add --all` to make sure we pick up any files which are removed, and `git commit --allow-empty` to allow empty commits (even though the jobs would be path-dependent, updates to tests could trigger a build without producing any output) We'd still have to have a think about how to deal with binary files though - I did think maybe git lfs would be a possible solution but apparently it doesn't work with GH pages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
