pitrou commented on a change in pull request #10907:
URL: https://github.com/apache/arrow/pull/10907#discussion_r687528200
##########
File path: cpp/src/arrow/compute/exec/key_hash.cc
##########
@@ -198,8 +198,10 @@ void Hashing::hash_varlen_helper(uint32_t length, const
uint8_t* key, uint32_t*
last_stripe[1] = last_stripe_base[1];
last_stripe[1] &= mask;
}
+ uint32_t lanes[4];
+ memcpy(&lanes, &last_stripe, sizeof(last_stripe));
for (int j = 0; j < 4; ++j) {
- uint32_t lane = reinterpret_cast<const uint32_t*>(last_stripe)[j];
Review comment:
This doesn't sound like a concern. The hash is only used internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
