nirandaperera commented on pull request #10802: URL: https://github.com/apache/arrow/pull/10802#issuecomment-898529526
Lol! Yes. I think that was a mistake from me! 😠On Fri, Aug 13, 2021, 11:05 Antoine Pitrou ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In cpp/src/arrow/compute/kernels/vector_selection.cc > <https://github.com/apache/arrow/pull/10802#discussion_r688584422>: > > > @@ -2146,6 +2147,219 @@ class TakeMetaFunction : public MetaFunction { > } > }; > > +// ---------------------------------------------------------------------- > +// DropNull Implementation > + > +Status GetDropNullFilter(const Array& values, MemoryPool* memory_pool, > > Hmm, I'm curious why @nirandaperera <https://github.com/nirandaperera> > suggested this. Returning Result<...> is the recommended convention in > all newly written code (an exception is when the out-parameter is optional, > and/or you have several of them). > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/10802#discussion_r688584422>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABKS65PYEWOTPW62DJEI2KDT4UYCXANCNFSM5BAK5SZA> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
