kou commented on a change in pull request #10932: URL: https://github.com/apache/arrow/pull/10932#discussion_r688734131
########## File path: .github/workflows/matlab.yml ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: MATLAB + +on: + push: + paths: + - '.github/workflows/matlab.yml' + - 'ci/scripts/matlab*.sh' + - 'matlab/**' + - 'cpp/src/arrow/**' + +concurrency: + group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + + matlab: + name: MATLAB + runs-on: ubuntu-latest + steps: + - name: Check out repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 + - name: Fetch Submodules and Tags + shell: bash Review comment: Could you remove redundant this line? (`bash` is the default on `ubuntu-latest`.) Other `.yml`s doesn't specify this. ########## File path: .github/workflows/matlab.yml ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: MATLAB + +on: + push: + paths: + - '.github/workflows/matlab.yml' + - 'ci/scripts/matlab*.sh' + - 'matlab/**' + - 'cpp/src/arrow/**' + +concurrency: + group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + + matlab: + name: MATLAB + runs-on: ubuntu-latest + steps: + - name: Check out repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 + - name: Fetch Submodules and Tags + shell: bash + run: ci/scripts/util_checkout.sh + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v0 + - name: Build MATLAB Interface + shell: bash + run: ci/scripts/matlab_build.sh $(pwd); Review comment: ```suggestion run: ci/scripts/matlab_build.sh $(pwd) ``` ########## File path: .github/workflows/matlab.yml ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: MATLAB + +on: + push: + paths: + - '.github/workflows/matlab.yml' + - 'ci/scripts/matlab*.sh' + - 'matlab/**' + - 'cpp/src/arrow/**' + +concurrency: + group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + + matlab: + name: MATLAB + runs-on: ubuntu-latest + steps: + - name: Check out repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 + - name: Fetch Submodules and Tags + shell: bash + run: ci/scripts/util_checkout.sh + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v0 + - name: Build MATLAB Interface + shell: bash Review comment: Ditto. ########## File path: .github/workflows/matlab.yml ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: MATLAB + +on: + push: + paths: + - '.github/workflows/matlab.yml' + - 'ci/scripts/matlab*.sh' + - 'matlab/**' + - 'cpp/src/arrow/**' Review comment: Could you also add `pull_request` entry to `on`? So we can run this before merging a pull request. ########## File path: .github/workflows/matlab.yml ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: MATLAB + +on: + push: + paths: + - '.github/workflows/matlab.yml' + - 'ci/scripts/matlab*.sh' + - 'matlab/**' + - 'cpp/src/arrow/**' + +concurrency: + group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + + matlab: + name: MATLAB + runs-on: ubuntu-latest + steps: + - name: Check out repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 + - name: Fetch Submodules and Tags + shell: bash + run: ci/scripts/util_checkout.sh + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v0 + - name: Build MATLAB Interface Review comment: https://github.com/mathworks/arrow/runs/3323642808 It seems that this step takes 18m+ (mostly Apache Arrow C++ build). Can we reduce the build time by using `ccache` and/or [`CMAKE_BUILD_PARALLEL_LEVEL`](https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html) environment variable (or using `ninja` instead of `make`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
