emkornfield commented on a change in pull request #10901:
URL: https://github.com/apache/arrow/pull/10901#discussion_r690014433



##########
File path: 
java/vector/src/test/java/org/apache/arrow/vector/util/DecimalUtilityTest.java
##########
@@ -41,7 +41,8 @@ public void testSetLongInDecimalArrowBuf() {
       ) {
         int [] intValues = new int [] {Integer.MAX_VALUE, Integer.MIN_VALUE, 
0};
         for (int val : intValues) {
-          buf.clear();

Review comment:
       given these changes, I think maybe we should keep clear() and remove all 
the rest.  adding more calls for readerIndex and writeIndex seems like it is 
moving in the wrong direction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to