yjshen commented on a change in pull request #811:
URL: https://github.com/apache/arrow-datafusion/pull/811#discussion_r690067772
##########
File path: ballista/rust/scheduler/src/lib.rs
##########
@@ -285,24 +286,19 @@ impl SchedulerGrpc for SchedulerServer {
match file_type {
FileType::Parquet => {
- let parquet_exec =
- ParquetExec::try_from_path(&path, None, None, 1024, 1,
None)
- .map_err(|e| {
- let msg = format!("Error opening parquet files:
{}", e);
- error!("{}", msg);
- tonic::Status::internal(msg)
- })?;
+ let ctx = create_datafusion_context_concurrency(1);
+ let parquet_desc = ParquetRootDesc::new(&path,
ctx).map_err(|e| {
+ let msg = format!("Error opening parquet files: {}", e);
+ error!("{}", msg);
+ tonic::Status::internal(msg)
+ })?;
//TODO include statistics and any other info needed to
reconstruct ParquetExec
Ok(Response::new(GetFileMetadataResult {
- schema: Some(parquet_exec.schema().as_ref().into()),
- partitions: parquet_exec
- .partitions()
- .iter()
- .map(|part| FilePartitionMetadata {
- filename: part.filenames().to_vec(),
- })
- .collect(),
+ schema: Some(parquet_desc.schema().as_ref().into()),
+ partitions: vec![FilePartitionMetadata {
+ filename: vec![path],
Review comment:
The behavior is unchanged indeed, the origin filenames all comes from
the root_path, and here I just use the root_path instead, to avoid touching too
much code in ballista proto definition as well as its serde (to_proto and
from_proto)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
