pitrou commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r691331643
##########
File path: cpp/src/arrow/testing/random.cc
##########
@@ -998,6 +1004,36 @@ std::shared_ptr<arrow::RecordBatch> GenerateBatch(const
FieldVector& fields,
int64_t length, SeedType
seed) {
return RandomArrayGenerator(seed).BatchOf(fields, length);
}
-
} // namespace random
+
+void rand_day_millis(int64_t N,
std::vector<DayTimeIntervalType::DayMilliseconds>* out) {
+ const int random_seed = 0;
+ std::default_random_engine gen(random_seed);
Review comment:
Since we're using `pcg32_fast` in RandomArrayGenerator, use it here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
