lidavidm commented on a change in pull request #10845:
URL: https://github.com/apache/arrow/pull/10845#discussion_r691404976
##########
File path: cpp/src/arrow/compute/exec/options.h
##########
@@ -111,5 +111,32 @@ class ARROW_EXPORT SinkNodeOptions : public
ExecNodeOptions {
std::function<Future<util::optional<ExecBatch>>()>* generator;
};
+enum JoinType {
Review comment:
Hmm. The C++ style guide doesn't say anything. I would say enum class is
generally preferred in modern C++. We semi-intentionally use plain enum in a
few places (when nested inside a struct) but I'm not sure why we have that
pattern.
This isn't the only place where this happens so it's not a big deal, but I
would prefer enum class so that it's not implicitly converted and so that
namespacing is explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
