bkietz commented on a change in pull request #10876:
URL: https://github.com/apache/arrow/pull/10876#discussion_r692045221
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -2257,6 +2381,21 @@ void RegisterHashAggregateBasic(FunctionRegistry*
registry) {
DCHECK_OK(func->AddKernel(MakeKernel(boolean(),
HashAggregateInit<GroupedAllImpl>)));
DCHECK_OK(registry->AddFunction(std::move(func)));
}
+
+ {
+ auto func = std::make_shared<HashAggregateFunction>(
+ "hash_count_distinct", Arity::Binary(), &hash_count_distinct_doc);
+ DCHECK_OK(func->AddKernel(
+ MakeKernel(ValueDescr::ARRAY,
HashAggregateInit<GroupedCountDistinctImpl>)));
Review comment:
Concretely: if a type is unsupported by Grouper then as currently
written we won't detect that error until the first call to `consume`. Among
other things, that means that an `Expression` would successfully bind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
