lidavidm commented on a change in pull request #10806:
URL: https://github.com/apache/arrow/pull/10806#discussion_r692331241
##########
File path: cpp/src/arrow/array/builder_binary.h
##########
@@ -274,6 +274,23 @@ class BaseBinaryBuilder : public ArrayBuilder {
return Status::OK();
}
+ Status AppendArraySliceUnchecked(const ArrayData& array, int64_t offset,
+ int64_t length) override {
+ auto bitmap = array.GetValues<uint8_t>(0, 0);
+ auto offsets = array.GetValues<offset_type>(1);
+ auto data = array.GetValues<uint8_t>(2, 0);
+ for (int64_t i = 0; i < length; i++) {
+ if (!bitmap || BitUtil::GetBit(bitmap, array.offset + offset + i)) {
Review comment:
It's actually slower, due to overhead in BitRunReader. Compare the
[profile using BitRunReader](https://share.firefox.dev/3ATXEbH) to the one
[without](https://share.firefox.dev/37WHkdT).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
