lidavidm commented on a change in pull request #10942:
URL: https://github.com/apache/arrow/pull/10942#discussion_r692413118
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -1104,6 +1130,17 @@ struct GroupedProductImpl final : public
GroupedAggregator {
BitUtil::SetBitTo(null_bitmap->mutable_data(), i, false);
}
+ if (!options_.skip_nulls) {
+ null_count = kUnknownNullCount;
+ if (null_bitmap) {
+ arrow::internal::BitmapAnd(null_bitmap->data(), /*left_offset=*/0,
+ no_nulls_.data(), /*right_offset=*/0,
num_groups_,
+ /*out_offset=*/0,
null_bitmap->mutable_data());
+ } else {
+ ARROW_ASSIGN_OR_RAISE(null_bitmap, no_nulls_.Finish());
+ }
+ }
+
Review comment:
I've made all 5 kernels use CRTP. GroupedMeanImpl is kind of iffy under
this pattern but the other 4 kernels consolidate nicely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
