waynexia commented on pull request #792:
URL: https://github.com/apache/arrow-datafusion/pull/792#issuecomment-903865242


   >In short, I think it should be fine to include qualifiers in compound 
projection columns. The only thing is we need to make sure the behavior should 
be consistent before and after the subexpression elimination rule has been 
applied.
   
   Agree. 
   
   This optimize won't touch a single column expr, so only those with extra 
operators are affected by rewriting. And since a column name like 
`SUM(table1.id)` is acceptable, I propose that we can change the column name in 
nested expr to qualified form. I'd like to file a PR for this (in a few days :D)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to