pitrou commented on a change in pull request #10942:
URL: https://github.com/apache/arrow/pull/10942#discussion_r694119940
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -174,19 +172,23 @@ TEST(TestBooleanAggregation, Sum) {
ScalarAggregateOptions(/*skip_nulls=*/true,
/*min_count=*/2));
ValidateBooleanAgg<Sum>(json, std::make_shared<UInt64Scalar>(),
ScalarAggregateOptions(/*skip_nulls=*/true,
/*min_count=*/3));
- ValidateBooleanAgg<Sum>(json, std::make_shared<UInt64Scalar>(1),
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/1));
- ValidateBooleanAgg<Sum>(json, std::make_shared<UInt64Scalar>(1),
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/2));
+ ValidateBooleanAgg<Sum>("[]", std::make_shared<UInt64Scalar>(0),
+ ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
ValidateBooleanAgg<Sum>(json, std::make_shared<UInt64Scalar>(),
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/3));
+ ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
Review comment:
Ping here.
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -744,20 +771,10 @@ TYPED_TEST(TestMeanKernelNumeric, ScalarAggregateOptions)
{
ValidateMean<TypeParam>("[]", nan_result,
ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
- ValidateMean<TypeParam>("[null]", nan_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
- ValidateMean<TypeParam>("[]", null_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/1));
ValidateMean<TypeParam>("[null]", null_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/1));
- ValidateMean<TypeParam>(json, expected_result,
ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
- ValidateMean<TypeParam>(json, expected_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/3));
- ValidateMean<TypeParam>(json, expected_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/4));
ValidateMean<TypeParam>(json, null_result,
- ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/15));
+ ScalarAggregateOptions(/*skip_nulls=*/false,
/*min_count=*/0));
Review comment:
It seems like there should be some tests with `skip_nulls=false` and a
non-zero `min_count`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
