michalursa commented on a change in pull request #10858:
URL: https://github.com/apache/arrow/pull/10858#discussion_r694567945
##########
File path: cpp/src/arrow/compute/exec/key_encode.cc
##########
@@ -1366,8 +1377,8 @@ void KeyEncoder::KeyRowMetadata::FromColumnMetadataVector(
// a) Boolean column, marked with fixed-length 0, is considered to have
fixed-length
// part of 1 byte. b) Columns with fixed-length part being power of 2 or
multiple of row
// alignment precede other columns. They are sorted among themselves based
on size of
- // fixed-length part. c) Fixed-length columns precede varying-length columns
when both
- // have the same size fixed-length part.
+ // fixed-length part decreasing. c) Fixed-length columns precede
varying-length columns
Review comment:
changed
##########
File path: cpp/src/arrow/compute/exec/key_encode.cc
##########
@@ -864,6 +864,17 @@ void KeyEncoder::EncoderBinaryPair::Encode(uint32_t
offset_within_row, KeyRowArr
EncodeImp_fn[dispatch_const](num_processed, offset_within_row, rows,
col_prep[0],
col_prep[1]);
}
+
+ DCHECK(temp1->metadata().is_fixed_length);
+ DCHECK(temp1->length() * temp1->metadata().fixed_length >=
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
