jorgecarleitao commented on a change in pull request #10984:
URL: https://github.com/apache/arrow/pull/10984#discussion_r694888370
##########
File path: format/Schema.fbs
##########
@@ -206,9 +206,20 @@ table Date {
enum TimeUnit: short { SECOND, MILLISECOND, MICROSECOND, NANOSECOND }
-/// Time type. The physical storage type depends on the unit
-/// - SECOND and MILLISECOND: 32 bits
-/// - MICROSECOND and NANOSECOND: 64 bits
+/// Time is either a 32-bit or 64-bit integer type representing an elapsed time
+/// since midnight, stored in either of four units: seconds, milliseconds,
+/// microseconds or nanoseconds.
+///
+/// The integer `bitWidth` depends on the `unit` and must be one of the
following:
+/// * SECOND and MILLISECOND: 32 bits
+/// * MICROSECOND and NANOSECOND: 64 bits
+///
+/// The allowed values are between 0 (inclusive) and 86400 (exclusive),
adjusted
Review comment:
```suggestion
/// The allowed values are between 0 (inclusive) and 86400 (=24*60*60)
seconds (exclusive), adjusted
```
##########
File path: format/Schema.fbs
##########
@@ -206,9 +206,20 @@ table Date {
enum TimeUnit: short { SECOND, MILLISECOND, MICROSECOND, NANOSECOND }
-/// Time type. The physical storage type depends on the unit
-/// - SECOND and MILLISECOND: 32 bits
-/// - MICROSECOND and NANOSECOND: 64 bits
+/// Time is either a 32-bit or 64-bit integer type representing an elapsed time
Review comment:
```suggestion
/// Time is either a 32-bit or 64-bit signed integer type representing an
elapsed time
```
##########
File path: format/Schema.fbs
##########
@@ -206,9 +206,20 @@ table Date {
enum TimeUnit: short { SECOND, MILLISECOND, MICROSECOND, NANOSECOND }
-/// Time type. The physical storage type depends on the unit
-/// - SECOND and MILLISECOND: 32 bits
-/// - MICROSECOND and NANOSECOND: 64 bits
+/// Time is either a 32-bit or 64-bit integer type representing an elapsed time
+/// since midnight, stored in either of four units: seconds, milliseconds,
+/// microseconds or nanoseconds.
+///
+/// The integer `bitWidth` depends on the `unit` and must be one of the
following:
+/// * SECOND and MILLISECOND: 32 bits
+/// * MICROSECOND and NANOSECOND: 64 bits
+///
+/// The allowed values are between 0 (inclusive) and 86400 (exclusive),
adjusted
+/// for the time unit (for example, up to 86400000 exclusive for the
MILLISECOND
+/// unit).
+/// This definition doesn't allow for leap seconds. If converting data from a
Review comment:
```suggestion
/// This definition doesn't allow for leap seconds. If converting data from a
```
##########
File path: format/Schema.fbs
##########
@@ -206,9 +206,20 @@ table Date {
enum TimeUnit: short { SECOND, MILLISECOND, MICROSECOND, NANOSECOND }
-/// Time type. The physical storage type depends on the unit
-/// - SECOND and MILLISECOND: 32 bits
-/// - MICROSECOND and NANOSECOND: 64 bits
+/// Time is either a 32-bit or 64-bit integer type representing an elapsed time
+/// since midnight, stored in either of four units: seconds, milliseconds,
+/// microseconds or nanoseconds.
+///
+/// The integer `bitWidth` depends on the `unit` and must be one of the
following:
+/// * SECOND and MILLISECOND: 32 bits
+/// * MICROSECOND and NANOSECOND: 64 bits
+///
+/// The allowed values are between 0 (inclusive) and 86400 (exclusive),
adjusted
+/// for the time unit (for example, up to 86400000 exclusive for the
MILLISECOND
+/// unit).
+/// This definition doesn't allow for leap seconds. If converting data from a
+/// system which may produce leap seconds, it will be necessary to adjust
incoming
Review comment:
alternative wording:
> Times from systems with leap seconds must be adjusted to the leap-less
format when converted to this system (for example by converting 86400 to 86399).
##########
File path: format/Schema.fbs
##########
@@ -194,8 +194,8 @@ enum DateUnit: short {
MILLISECOND
}
-/// Date is either a 32-bit or 64-bit type representing elapsed time since UNIX
-/// epoch (1970-01-01), stored in either of two units:
+/// Date is either a 32-bit or 64-bit integer type representing an elapsed time
Review comment:
```suggestion
/// Date is either a 32-bit or 64-bit signed integer type representing an
elapsed time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
