emkornfield commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r695034020
##########
File path: format/FlightSql.proto
##########
@@ -0,0 +1,454 @@
+/*
Review comment:
General comment. Instead of StringValue we should use "optional string
field = 1". Proto3 was revised to support this [for checking for
presence](https://stackoverflow.com/questions/42622015/how-to-define-an-optional-field-in-protobuf-3)
Its not clear to me if optional should be used in all cases (it might be
sufficient to denote empty as interpreted as not specified).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
