seddonm1 commented on a change in pull request #706:
URL: https://github.com/apache/arrow-rs/pull/706#discussion_r695219531



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -450,6 +450,250 @@ pub fn nlike_utf8_scalar<OffsetSize: 
StringOffsetSizeTrait>(
     Ok(BooleanArray::from(data))
 }
 
+/// Perform SQL `array ~ regex_array` operation on [`StringArray`] / 
[`LargeStringArray`].
+pub fn regexp_matches_utf8<OffsetSize: StringOffsetSizeTrait>(

Review comment:
       This looks like the 
https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-POSIX-TABLE
 functionality which uses an Operator `~` to instead of a function. I think the 
kernel names are fine but it would be nice if we could retain the postgres 
semantics in order to achieve as much compatibility as possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to