alamb commented on a change in pull request #939:
URL: https://github.com/apache/arrow-datafusion/pull/939#discussion_r695220554
##########
File path: datafusion/src/physical_plan/windows/window_agg_exec.rs
##########
@@ -143,6 +143,18 @@ impl ExecutionPlan for WindowAggExec {
));
Ok(stream)
}
+
+ fn fmt_as(
+ &self,
+ t: DisplayFormatType,
+ f: &mut std::fmt::Formatter,
+ ) -> std::fmt::Result {
+ match t {
+ DisplayFormatType::Default => {
+ write!(f, "WindowAggExec")
Review comment:
I think might be worth including self.window_expr (aka ` window_expr:
Vec<Arc<dyn WindowExpr>>`) as well
You can check out
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/hash_aggregate.rs#L260-L272
for an example
##########
File path: ballista/rust/core/src/execution_plans/distributed_query.rs
##########
@@ -186,6 +187,22 @@ impl ExecutionPlan for DistributedQueryExec {
};
}
}
+
+ fn fmt_as(
+ &self,
+ t: DisplayFormatType,
+ f: &mut std::fmt::Formatter,
+ ) -> std::fmt::Result {
+ match t {
+ DisplayFormatType::Default => {
+ write!(
+ f,
+ "DistributedQueryExec: scheduler_url={}",
Review comment:
👍 for including `scheduler_url`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
