ianmcook commented on a change in pull request #10992:
URL: https://github.com/apache/arrow/pull/10992#discussion_r695876860
##########
File path: r/tests/testthat/test-dplyr-aggregate.R
##########
@@ -188,8 +194,32 @@ test_that("Filter and aggregate", {
filter(int > 5) %>%
group_by(some_grouping) %>%
summarize(total = sum(int, na.rm = TRUE)) %>%
- arrange(some_grouping) %>%
collect(),
tbl
)
})
+
+test_that("Expressions on aggregations", {
+ # This is what it effectively is
+ expect_dplyr_equal(
+ input %>%
+ group_by(some_grouping) %>%
+ summarize(
+ any = any(lgl),
+ all = all(lgl)
+ ) %>%
+ collect() %>%
Review comment:
More accurate representation of what this effectively is:
```suggestion
compute() %>%
```
(The `transmute()` below this is operating on an Arrow Table, not an R data
frame.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
