lidavidm commented on a change in pull request #10994:
URL: https://github.com/apache/arrow/pull/10994#discussion_r695998614
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -1833,30 +1853,45 @@ struct GroupedBooleanAggregator : public
GroupedAggregator {
uint8_t* seen = seen_.mutable_data();
uint8_t* no_nulls = no_nulls_.mutable_data();
int64_t* counts = counts_.mutable_data();
- const auto& input = *batch[0].array();
auto g = batch[1].array()->GetValues<uint32_t>(1);
- if (input.MayHaveNulls()) {
- const uint8_t* bitmap = input.buffers[1]->data();
- arrow::internal::VisitBitBlocksVoid(
- input.buffers[0], input.offset, input.length,
- [&](int64_t position) {
- counts[*g]++;
- Impl::UpdateGroupWith(seen, *g, BitUtil::GetBit(bitmap, position));
- g++;
- },
- [&] { BitUtil::SetBitTo(no_nulls, *g++, false); });
+ if (batch[0].is_array()) {
+ const auto& input = *batch[0].array();
+ if (input.MayHaveNulls()) {
+ const uint8_t* bitmap = input.buffers[1]->data();
+ arrow::internal::VisitBitBlocksVoid(
+ input.buffers[0], input.offset, input.length,
+ [&](int64_t position) {
+ counts[*g]++;
+ Impl::UpdateGroupWith(seen, *g, BitUtil::GetBit(bitmap,
position));
+ g++;
+ },
+ [&] { BitUtil::SetBitTo(no_nulls, *g++, false); });
+ } else {
+ arrow::internal::VisitBitBlocksVoid(
+ input.buffers[1], input.offset, input.length,
+ [&](int64_t) {
+ Impl::UpdateGroupWith(seen, *g, true);
Review comment:
`seen` is perhaps a poor name (I'll rename it) but it's the current
value of the aggregation (i.e. `any_true` or `all_true`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
