sergiimk opened a new pull request #721:
URL: https://github.com/apache/arrow-rs/pull/721
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #713.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Formatting of `DECIMAL` in schemas where only `ConvertedType` is present and
not `LogicalType` was broken.
This is the case for parquet files produced by Spark.
# What changes are included in this PR?
I also had to update `decimal_length_from_precision` function as the math
there seemed off.
When used as `.with_length(decimal_length_from_precision(19))` it resulted
in a panic:
```
Cannot represent FIXED_LEN_BYTE_ARRAY as DECIMAL with length 8 and precision
19. The max precision can only be 18
```
<!---
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
`print_schema` will no longer produce malformed results for decimals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
