cpcloud commented on a change in pull request #10934:
URL: https://github.com/apache/arrow/pull/10934#discussion_r697551237



##########
File path: format/experimental/computeir/InlineBuffer.fbs
##########
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       > I'd also avoid sprinkling in non-canonical all over the place unless 
there is a real need. For example, why would I have a "non-canonical set op" as 
opposed to just having a new CustomRelation?
   
   Good point. Will remove that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to