Dandandan commented on a change in pull request #716:
URL: https://github.com/apache/arrow-rs/pull/716#discussion_r697698498
##########
File path: arrow/src/array/transform/utils.rs
##########
@@ -74,3 +103,130 @@ pub(super) unsafe fn get_last_offset<T: OffsetSizeTrait>(
debug_assert!(prefix.is_empty() && suffix.is_empty());
*offsets.get_unchecked(offsets.len() - 1)
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn test_set_bits_aligned() {
+ let mut destination: Vec<u8> = vec![0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
+ let source: &[u8] = &[
+ 0b11100111, 0b11100111, 0b11100111, 0b11100111, 0b11100111,
0b11100111,
+ 0b11100111, 0b11100111,
+ ];
+
+ let destination_offset = 8;
+ let source_offset = 0;
+
+ let len = 64;
+
+ let expected_data: &[u8] = &[
+ 0, 0b11100111, 0b11100111, 0b11100111, 0b11100111, 0b11100111,
0b11100111,
+ 0b11100111, 0b11100111, 0,
+ ];
+ let expected_null_count = 16;
+ let result = set_bits(
+ destination.as_mut_slice(),
+ source,
+ destination_offset,
+ source_offset,
+ len,
+ );
+
+ assert_eq!(destination, expected_data);
+ assert_eq!(result, expected_null_count);
+ }
+
+ #[test]
+ fn test_set_bits_unaligned_destination_start() {
+ let mut destination: Vec<u8> = vec![0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
+ let source: &[u8] = &[
+ 0b11100111, 0b11100111, 0b11100111, 0b11100111, 0b11100111,
0b11100111,
+ 0b11100111, 0b11100111,
+ ];
+
+ let destination_offset = 3;
+ let source_offset = 0;
+
+ let len = 64;
+
+ let expected_data: &[u8] = &[
+ 0b00111000, 0b00111111, 0b00111111, 0b00111111, 0b00111111,
0b00111111,
+ 0b00111111, 0b00111111, 0b00000111, 0b00000000,
Review comment:
To me this looks to be correct, the last 3 bits on the left from the
source byte end up on the right of the last destination byte (set bits go from
right to left)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
