waynexia opened a new pull request #952:
URL: https://github.com/apache/arrow-datafusion/pull/952
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Origin in #792, some discussions here:
https://github.com/apache/arrow-datafusion/pull/792#issuecomment-902936271
In the current implementation and spec., all field names don't contain the
table or relation name. It might be better to hold those qualifiers in compound
columns resulting from projection with calculating expr (`select t1 + 1`) or
aggr expr (`sum(t2)`) etc. This can improve readability by figuring out where a
column is from. And also in some parts of inner processing (like the logical
plan phase), we use this qualified form to identify a column.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR changes the rule of field name generation. For now, all compound
columns' (columns with other outer expressions) field names will be qualified
form.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Yes.
Compound columns' field name will now contain table / relation name, like
`AVG(table.c1)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
