lidavidm commented on pull request #10845: URL: https://github.com/apache/arrow/pull/10845#issuecomment-907635421
Ah ok, I wasn't sure how to read the check here. Maybe instead of > 0, there should be a separate check for keys.size() == 0 that returns an error? On Sat, Aug 28, 2021, at 10:34, niranda perera wrote: > > > ***@***.**** commented on this pull request. > > > In cpp/src/arrow/compute/exec/hash_join_node.cc <https://github.com/apache/arrow/pull/10845#discussion_r697877600>: > > > @@ -39,7 +39,7 @@ Status ValidateJoinInputs(const std::shared_ptr<Schema>& left_schema, > const std::shared_ptr<Schema>& right_schema, > const std::vector<int>& left_keys, > const std::vector<int>& right_keys) { > - if (left_keys.size() != right_keys.size()) { > + if (left_keys.size() != right_keys.size() && left_keys.size() > 0) { > > AFAIK I don't think it's valid. We'd need some indexer if no key columns are specified > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/arrow/pull/10845#discussion_r697877600>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQB37IK6TUN3H7WDD7XTTT7DXY5ANCNFSM5BJEPLZQ>. > Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
