[GitHub] [arrow] HashidaTKS commented on a change in pull request #10990: ARROW-13704: [C#] Add support for reading streaming format delta dictionaries

[GitBox]

HashidaTKS commented on a change in pull request #10990:
URL: https://github.com/apache/arrow/pull/10990#discussion_r697884564



##########
File path: csharp/src/Apache.Arrow/Ipc/ArrowReaderImplementation.cs
##########
@@ -144,7 +154,7 @@ private void ReadDictionaryBatch(Flatbuf.DictionaryBatch 
dictionaryBatch, ByteBu
 
             if (dictionaryBatch.IsDelta)
             {
-                throw new NotImplementedException("Dictionary delta is not 
supported yet");
+                DictionaryMemo.AddDeltaDictionary(id, arrays[0], _allocator);

Review comment:
       Creating `arrays` for a delta dictionary causes needless memory 
allocation for  `ArrowArray`.
   It's enough to create just `ArrayData` for the delta dictionary.
   I plan to fix it with a future PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org