jorisvandenbossche commented on a change in pull request #11008:
URL: https://github.com/apache/arrow/pull/11008#discussion_r698259018
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -1998,6 +1998,41 @@ cdef class PartitioningFactory(_Weakrefable):
cdef inline shared_ptr[CPartitioningFactory] unwrap(self):
return self.wrapped
+ @property
+ def type_name(self):
+ return frombytes(self.factory.type_name())
+
+ def create_with_schema(self, schema):
Review comment:
And note that for *reading*, we already do this: as a user, you in
theory never have to use a PartitioningFactory, as you can either pass
`partitioning="hive"` or `partitioning=["field", "names"]` (for directory
partitioning) to the `dataset(..)` function. Those are both shortcuts for using
`ds.partitioning()` in the case it returns a factory.
But yes, we designed this API when there was only reading and not yet
writing ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
